BUTTON_OnClick two part question

Name	Points
Greg Moeller	4184
David Williams	3349
JonA	3288
Kat V	2984
Woozy	1973
Jimmy Chiu	1883
Kwane McNeal	1437
Ragu Raghavan	1351
Roger French	1311
mark.cook	1244

brihyn

Veteran Member

Posts: 95

7/21/2009 6:17 PM

Having trouble thinking this through today...I'm sure I'm doing something dumb, but I'm not seeing it.
I have a button on a couple of forms that brings up a search window of related scanned images
Script looks like this:
function BUTTON_OnClick(button)
{
if (button == "push12")
{
  var VenNum = lawForm.getFormValue("text2");
  VenNum = trim(VenNum);
  var ImageUrl = "/search/vendorsearch.asp?query=%23filename%3D%22" + VenNum + "_*.*%22";
  window.open(ImageUrl);
}
// return true;
}

problem 1- The new image button works great, but just found out that my script is keeping any of the default buttons from working. Clicking on them, nothing happens. How do i map the one button in the script without affecting other buttons?
Second, possibly related, possibly not-
When I un-remark the return true line, clicking on the button will still cause my search to work, but then i get an ios error stating, in effect, Missing required parameter: _TKN. Any ideas?

Thanks as always!

David Williams

Veteran Member

Posts: 1127

7/21/2009 6:34 PM

Change your line to
if (button != "push12") return true;
{
so all of the other buttons will process as normal and your script will only run when the button == push12. After doing that, see if your other error is also resolved and if not report back.

brihyn

Veteran Member

Posts: 95

7/21/2009 6:48 PM

With
if (button != "push12") return true;
{
The other buttons all work, but clicking on the button 12, I get the com.lawson.ios.agent.AgentException: Missing required parameter: _TKN. error, and my popup never shows.

Gary Davies

Veteran Member

Posts: 248

7/21/2009 6:56 PM

You don't have to check if the button is not push12, if you uncomment the return true that will do the same thing.

What version of DS are you on? the BUTTON_OnClick should pass (id, row) with id being "push12"

Michael Thedford

Advanced Member

Posts: 19

7/21/2009 6:57 PM

Not sure what the button test (if statement) portion of the function is for, since we do not know how you have your button defined. From what it looks like, all you need is a function called GetImage or anything of your choosing.

function GetImage()

{
var VenNum = lawForm.getFormValue("text2");
if (VenNum == '')
(
alert ("Cannot Display image without a valid Vendor Number value on the form.");
return false;
)
VenNum = trim(VenNum);
var ImageUrl = "/search/vendorsearch.asp?query=%23filename%3D%22" + VenNum + "_*.*%22";
window.open(ImageUrl);
return true;
}

Define your button Action as: Function, then select the GetImage function from the function name list. When that button is clicked, it will only run that fuction and will not affect any other buttons.

Hope that helps

brihyn

Veteran Member

Posts: 95

7/21/2009 7:13 PM

Define your button Action as: Function, then select the GetImage function from the function name list. When that button is clicked, it will only run that fuction and will not affect any other buttons.

Hope that helps

I think this is getting closer. I messed a little with the function option on the button. I selected Function now, and there's no options to pick from. I typed in GetImage but preview of the form, the button isn't doing a thing now. Am I missing a step to make the function a listed function?

Gary Davies

Veteran Member

Posts: 248

7/21/2009 7:21 PM

You have () instead of {} within the statement of the first if statement there, that would cause the function not to be evaluated and thus not show as available to select from.

brihyn

Veteran Member

Posts: 95

7/21/2009 7:22 PM

You have () instead of {} within the statement of the first if statement there, that would cause the function not to be evaluated and thus not show as available to select from.

good catch, but it actually wouldn't let me apply the script with the ()s. Already had it switched to {} and unfortunately still doesn't show in a list of functions, and the button doesn't do a thing.

David Williams

Veteran Member

Posts: 1127

7/21/2009 7:35 PM

Please attach your script in a text file to this forum so we can review it.

brihyn

Veteran Member

Posts: 95

7/21/2009 7:42 PM

here's everything I have on my scripts page (for reference)
function trim(str)
{
return str.replace(/^\s+|\s+$/g,"");
}

function GetImage()
{
var VenNum = lawForm.getFormValue("text2");
if (VenNum == '')
{
alert ("Cannot Display image without a valid Vendor Number value on the form.");
return false;
}
VenNum = trim(VenNum);
var ImageUrl = "/search/vendorsearch.asp?query=%23filename%3D%22" + VenNum + "_*.*%22";
window.open(ImageUrl);
return true;
}

On the button, I have Function selected, and GetImage in the space.

brihyn

Veteran Member

Posts: 95

7/21/2009 7:46 PM

txt file attached

Attachments

image.txt

Michael Thedford

Advanced Member

Posts: 19

7/21/2009 8:04 PM

After making the changes on the Script page, are you then going to Edit / Apply Changes - to actually apply the script changes you made? After that, it should be a valid fuction to select from when you select your custom button, select Action from it's properties, select Function as the Action type, then all fuctions on the script page should be listed to select from.

Also, put an alert after the "VenNum = trim(VenNum);" to see what that value is at that point.

Gary Davies

Veteran Member

Posts: 248

7/21/2009 8:10 PM

It sounds stupid, but try deleting any extra spaces you have at the end of the function line. I have found that works before.

Michael Thedford

Advanced Member

Posts: 19

7/21/2009 8:23 PM

It may also want a CR/LF after the last "}" in the function. Sorry about the "()" instead of the "{}"'s earlier in the thread. Darn high resolution settings and small font...

Gary Davies

Veteran Member

Posts: 248

7/21/2009 8:46 PM

Even if you don't see it listed, you should still be able to use it. Just type GetImage() in the line on top, this has worked for me in the past too when functions don't display in the list.

brihyn

Veteran Member

Posts: 95

7/22/2009 1:36 PM

wow, gotta love issues like this. Got rid of all of the spaces and extra carriage returns and sure enough, GetImage() shows up now, and the script works like a charm. Thanks everyone!